v5.49 - Feedback

MacroDroidDev

Administrator
Staff member
OK.
But may I ask You a question considering the other bugs? Do You plan to fix the described problem with the 'Not in Call' condition while talking and receiving another incoming call? I ask to understand if should I search some workaround for this bug or simply wait for your fix. Thanx.
It's not something I plan to look at any time soon. This is not anything new or related to this beta in any way. I've looked at the code and it's not even clear if it will be fixable because MacroDroid simply queries the telephony manager to ask it if a call is in progress. I will add it to my long term list of things to look at but no timescales on this.
 

MacroDroidDev

Administrator
Staff member
Having spent a second look, I confirm it's sorted. But here it's not a question of sorting within groups of local or global variables but in these examples the variables were grouped by their type (string / integer / array).
Afaik, in the other selections, such groupings are not applied, which in my very personal opinion is more convenient for searching a variable.

For sure, this is totally up to you...
🤠

Ok, I think in this case it puts all Strings at the top and then arrays/dictionaries after, the sort order probably wasn't intentional so I'll try and do a sort on this. Might be in the next beta if one is needed or if not, it will be in the 5.50 update.
 

pluto25

Member
Thx, but really don't waste your time. This is not at all a bug, it is only a small piece intended to further optimize your brilliant MD!
🤠
 

GamBIT

Member
Actually, having just tested, i realize the issue was/is when you call an action block from a macro.
I get it with run macro action in the macro's body too.

I think MD could watch for both name and id. And to fix a broken name or id looking at another one. If a macro is deleted, id is absent, and MD would show an error. If we import a macro with the same name, MD would insert its ID into all the run macro actions and then remove the error highlighting.
As I now understand, we can point the macro to the run macro action using only a name, without id, and at this case we do not bump with the problem. But if we change the macro's name all the run macro actions would not execute this renamed macro. So, I think, a double control for the name and id would be the best.
 

md_sgf

Well-known member
Well, next time i need to replace a macro with another version of it, i will copy/paste code from imported macro into existing macro (rather than deleting or overwriting). This way, the same id is kept, and won't break other macros which refer to this one, thereby possibly saving a "truckload" of work. I've learnt my lesson! o_O🤕
 
5.49.5 version new issue! The variable change trigger does not fire; it only triggers when manually tested. I wrote a macro for an HTTP request push notification, which acquires the response by looping through the IP host address to open the website via HTTP. Then, it captures the receiver's IP address by responding to the receiver's HTTP request trigger and stores it in a variable named "new" on the current phone. This is used to push information to another phone using the HTTP request feature. (Two phones, A and B, are required; install this macro file on both phones A and B. Phone A turns on mobile data and creates a hotspot, while phone B connects to A's hotspot. The test for phone A's HTTP request to phone B's IP response is all normal. When testing phone B's request to phone A, there is a value echoed in the IP response, but the variable change trigger does not work. The log list already shows the response value echoed from phone A, yet the variable change trigger will not fire. However, when manually testing the trigger to run the macro, the variable change trigger can only be activated after the specified variable has been changed to the new value.) 😊 I can't figure out where the problem lies. Is it a bug in the variable change trigger or an issue with my macro?


As shown in the video, it's a bit long at 9 minutes, and the software language is set to English. 🙏🏻
After some research, I've found that: The HTTP page opening response receives the IP returned by the HTTP request, but the variable change trigger that is supposed to fire after the response value changes does not trigger. This is because the loop action list also uses the variable change trigger. By switching to a different trigger, the "new" variable can normally obtain the returned IP value. It seems that using multiple variable change triggers may cause some kind of conflict. Please, developers, verify and investigate the cause.
 

Attachments

  • IMG_20241130_125719.jpg
    IMG_20241130_125719.jpg
    258.3 KB · Views: 7
  • IMG_20241130_125701.jpg
    IMG_20241130_125701.jpg
    335.9 KB · Views: 7
  • IMG_20241130_125529.jpg
    IMG_20241130_125529.jpg
    328.8 KB · Views: 10
  • 推送通知_115712.macro
    39.3 KB · Views: 1
Last edited:

GamBIT

Member
Well, next time i need to replace a macro with another version of it, i will copy/paste code from imported macro into existing macro (rather than deleting or overwriting). This way, the same id is kept, and won't break other macros which refer to this one, thereby possibly saving a "truckload" of work. I've learnt my lesson! o_O🤕
Would the imported macro replace the existing one automatically? Before you could copy the code to paste.
 

pluto25

Member
Well, next time i need to replace a macro with another version of it, i will copy/paste code from imported macro into existing macro (rather than deleting or overwriting). This way, the same id is kept, and won't break other macros which refer to this one, thereby possibly saving a "truckload" of work. I've learnt my lesson! o_O🤕
Off topic: how/where to see the ID associated to a macro? 🤔
 

pluto25

Member
5.49.7: Array is not fully shown in <display dialog>

When choosing an array to be shown in a display dialog, I was used to get each array entry shown in full (what exactly matched my needs). Now, all entries are shown in a truncated manner (showing only 3 lines each). See screenshot and attached example macro.
🤠

Edit: the long screenshot shows how it looked like in 5.46.10
 

Attachments

  • Screenshot_20241130-173130_Trebuchet_1.png
    Screenshot_20241130-173130_Trebuchet_1.png
    154.2 KB · Views: 7
  • BUG_array_is_not_fully_shown.macro
    6.6 KB · Views: 2
  • Stitchcraft_20241130-185634.png
    Stitchcraft_20241130-185634.png
    3 MB · Views: 4
Last edited:

md_sgf

Well-known member
5.49.7: Array is not fully shown in <display dialog>

When choosing an array to be shown in a display dialog, I was used to get each array entry shown in full (what exactly matched my needs). Now, all entries are shown in a truncated manner (showing only 3 lines each). See screenshot and attached example macro.
It still shows the complete array in 5.49.3
 

md_sgf

Well-known member
Would the imported macro replace the existing one automatically? Before you could copy the code to paste.
I would save it with a different name (eg add "2" to end). Then copy from that. I do that usually anyway, when syncing macros between phones. I add a Macro Run action in main macro, so i can go between the 2 macros quickly, copy/pasting code blocks.
 

GamBIT

Member
I would save it with a different name (eg add "2" to end). Then copy from that. I do that usually anyway, when syncing macros between phones. I add a Macro Run action in main macro, so i can go between the 2 macros quickly, copy/pasting code blocks.
Did you try to point only the macro's name manually? It seems that way MD would search for the macro not by id but typed name.. ? So id wont brake.
 

GamBIT

Member
This is a broken macro where the animations no longer contain the duration values. I dont know if it can help but post it in hope the Developer can explore the reason. The values were fulfilled of course but somehow MD is losing it, since the feature was added to MD it wasnt fixed. So it isnt for the beta, but...
 

Attachments

  • Animation_bug.macro
    1.8 KB · Views: 3

MacroDroidDev

Administrator
Staff member
This is a broken macro where the animations no longer contain the duration values. I dont know if it can help but post it in hope the Developer can explore the reason. The values were fulfilled of course but somehow MD is losing it, since the feature was added to MD it wasnt fixed. So it isnt for the beta, but...

Thanks @GamBIT that was exactly what I needed. The issue was that in your macro the variable name field instead of being blank was being set to an empty string and my code incorrectly was assuming this meant you were using a (non-existent) variable instead of the actual value. I will put the fix in the the next (and hopefully final) beta.
 

MacroDroidDev

Administrator
Staff member
5.49.7: Array is not fully shown in <display dialog>

When choosing an array to be shown in a display dialog, I was used to get each array entry shown in full (what exactly matched my needs). Now, all entries are shown in a truncated manner (showing only 3 lines each). See screenshot and attached example macro.
🤠

Edit: the long screenshot shows how it looked like in 5.46.10
Thanks, I can see the truncation is happening in places where it should not be. I will put a fix in the next beta.
 

MacroDroidDev

Administrator
Staff member
5.49.5 version new issue! The variable change trigger does not fire; it only triggers when manually tested. I wrote a macro for an HTTP request push notification, which acquires the response by looping through the IP host address to open the website via HTTP. Then, it captures the receiver's IP address by responding to the receiver's HTTP request trigger and stores it in a variable named "new" on the current phone. This is used to push information to another phone using the HTTP request feature. (Two phones, A and B, are required; install this macro file on both phones A and B. Phone A turns on mobile data and creates a hotspot, while phone B connects to A's hotspot. The test for phone A's HTTP request to phone B's IP response is all normal. When testing phone B's request to phone A, there is a value echoed in the IP response, but the variable change trigger does not work. The log list already shows the response value echoed from phone A, yet the variable change trigger will not fire. However, when manually testing the trigger to run the macro, the variable change trigger can only be activated after the specified variable has been changed to the new value.) 😊 I can't figure out where the problem lies. Is it a bug in the variable change trigger or an issue with my macro?


As shown in the video, it's a bit long at 9 minutes, and the software language is set to English. 🙏🏻
After some research, I've found that: The HTTP page opening response receives the IP returned by the HTTP request, but the variable change trigger that is supposed to fire after the response value changes does not trigger. This is because the loop action list also uses the variable change trigger. By switching to a different trigger, the "new" variable can normally obtain the returned IP value. It seems that using multiple variable change triggers may cause some kind of conflict. Please, developers, verify and investigate the cause.
I've had a play around trying to recreate a similar problems with the variable change trigger not firing and I'm afraid I've not been able to recreate anything. Unfortunately a video that is so long with lots of Japanese characters is very hard too follow and I can't spend time watching it over and over again to try and make sense of it.

I don't believe whatever issue you are having here is related to this beta in any way so I'd like to stop dicussion of it here and request the following.

1) Swtich to the HTTP Request action (instead of Open Webpage) as this is what you should be using for HTTP Request nowadays.
2) If the problem persists please create a macro that exhibits the problem that I can easily run without lots of configuration and understanding required. If there is some steps needed then please list the steps to follow to recreate the issue.
3) Submit the bug using the standard report a bug mechansim in the troubleshooting section.
 

GamBIT

Member
the next bug I have mentioned earlier..

If we copy a trigger from one macro to another, and next edit its properties, MD can still refer to the old ones, showing the new properties.

The next macro shows 2 correct triggers and 2 incorrect.
The correct triggers are made inside the macro, Application Launched, with pointing the dictionary as a source for the applications. It works as expected.
The incorrect ones are copied from another macro with the other dictionary variable, next were edited. And it still continues to refer to that old variable 'Apps_selected_for_force_rotate', despite it has been changed to the 'Apps_selected_for_force_screen_on'. So the incorrect triggers fire when launching the app from the 'Apps_selected_for_force_rotate' dictionary while at the triggers is shown the 'Apps_selected_for_force_screen_on' dictionary. I have spent a lot of time trying to understand what is going on.

By the way, exporting this macro I have noticed that all the variables were not exported. Previously I thought that MD is exporting all related to the macro. No? Or it may be a part of the problem?

p.s.
It seems to me I haven't bumped into this problem some versions ago. Maybe it has appeared in some recent version.
 

Attachments

  • Bad Trigger.macro
    3.7 KB · Views: 4
Last edited:
Top