V5.37 - Feedback

dhj49er

Well-known member
Hello, having a problem with constraints, at the moment only noticed it when using "Bluetooth device connected" it always returns as false and prevents the action, even when the device is definitely connected. Must be an issue in the new version as these macros were working fine before the update and have not been changed since.

NOTE: I did submit a bug report in the app.
I've tried the BT device connected as a constraint and confirm the macro runs when the BT device is connected and doesn't run when disconnected.

It appears from what @Endercraft has said that this is a known issue....but not on every phone, which probably makes it more difficult to resolve.
 

Attachments

  • Screenshot_20230925_101322_MacroDroid.jpg
    Screenshot_20230925_101322_MacroDroid.jpg
    251.7 KB · Views: 7

CDA

Member
I've tried the BT device connected as a constraint and confirm the macro runs when the BT device is connected and doesn't run when disconnected.

It appears from what @Endercraft has said that this is a known issue....but not on every phone, which probably makes it more difficult to resolve.

Appreciate you testing that out.

Guess for now I will have to roll back my version of MD, hopefully uninstalling won't cause me any issues.
 

dhj49er

Well-known member
Appreciate you testing that out.

Guess for now I will have to roll back my version of MD, hopefully uninstalling won't cause me any issues.
Make sure you have a recent backup of your macros either stored locally or in the cloud, as uninstalling MD will delete all the macros

After installing MD and setting all the obvious permissions & turning off battery optimisations, I usually import the recent backup. MD then prompts for all the missing permissions. Finally you'll need to do the ADB hacks again.

Updating is a lot less hassle!!
 

CDA

Member
Make sure you have a recent backup of your macros either stored locally or in the cloud, as uninstalling MD will delete all the macros

After installing MD and setting all the obvious permissions & turning off battery optimisations, I usually import the recent backup. MD then prompts for all the missing permissions. Finally you'll need to do the ADB hacks again.

Updating is a lot less hassle!!
Damn, that's annoying. I don't mind the backup but all the settings and the ADB hack is a hassle. Hopefully an update will solve the problem.
 

MacroDroidDev

Administrator
Staff member
I don't believe the Bluetooth issue is in anyway related to the beta update. If I am remembering correctly the basic issue is that there is no way to query the currently connected bluetooth devices but instead we must listen for connected/disconnected events and store what is currently connected. This works fine most of the time but there can be situations where a device is connected before MacroDroid is running so at this point MacroDroid will not know that it is connected.

There can be subtle rare cases like if the OS decides to kill and restart MacroDroid it may take several seconds before MacroDroid is active again and during this time if a Bluetooth connect/disconnect happens it can be missed.
 

Dimlos

Well-known member
There are two versions of V5.37.3. I think this is a mistake in the description of V5.37.4. (File name is v5_37_4)
 

CDA

Member
I don't believe the Bluetooth issue is in anyway related to the beta update. If I am remembering correctly the basic issue is that there is no way to query the currently connected bluetooth devices but instead we must listen for connected/disconnected events and store what is currently connected. This works fine most of the time but there can be situations where a device is connected before MacroDroid is running so at this point MacroDroid will not know that it is connected.

There can be subtle rare cases like if the OS decides to kill and restart MacroDroid it may take several seconds before MacroDroid is active again and during this time if a Bluetooth connect/disconnect happens it can be missed.
Ok well the only way I can respond to that is that the bluetooth constraint I use on my podcast macro has worked perfectly for several months and stopped working completely when I did the beta update last week.
 

Endercraft

Moderator (& bug finder :D)
Ok well the only way I can respond to that is that the bluetooth constraint I use on my podcast macro has worked perfectly for several months and stopped working completely when I did the beta update last week.
Maybe update happened at same time (or play services was integrated to MacroDroid, I don't know how it works)
 

CDA

Member
Just seen there is a new update out this afternoon, installed that and now the bluetooth constraint is working again. Weird, but I'm not complaining.
 

sampleuserhere

Active member
I don't believe the Bluetooth issue is in anyway related to the beta update. If I am remembering correctly the basic issue is that there is no way to query the currently connected bluetooth devices but instead we must listen for connected/disconnected events and store what is currently connected. This works fine most of the time but there can be situations where a device is connected before MacroDroid is running so at this point MacroDroid will not know that it is connected.

There can be subtle rare cases like if the OS decides to kill and restart MacroDroid it may take several seconds before MacroDroid is active again and during this time if a Bluetooth connect/disconnect happens it can be missed.

I believe we can query the state with getMethod("isConnected"), CMIIW.

Similar method to the one in the reply I wrote below.

 

CDA

Member
Problem noticed this morning when editing a macro, when I move an action around MD crashes.

Edit : this appears to be limited to moving IF conditions around.
 
Last edited:

MacroDroidDev

Administrator
Staff member
@CDA thanks for the bug report. I'm not able to reproduce the issue with the macro you submitted in your bug report and I'm trying just about everything in terms of moving elements around. If possible can you show a screen recording to support@macrodroid.com that shows exactly what you are moving to make the crash.

If this is not possible can you describe exactly what you are moving from where to where when reordering items in the 'Floodlight' macro you sent me.
 
  • Like
Reactions: CDA

Dm114

Well-known member
I've just downloaded v5.37.4 and notice that IF CONFIRMED THEN action doesn't work anymore. I mean it's impossible to create a new macro with it: the line appears with a warning on pink background. As well as previous macros with such an action cannot be updated/saved anyway for the same reason. Thanks @MacroDroidDev for having a look on it...
 

CDA

Member
@CDA thanks for the bug report. I'm not able to reproduce the issue with the macro you submitted in your bug report and I'm trying just about everything in terms of moving elements around. If possible can you show a screen recording to support@macrodroid.com that shows exactly what you are moving to make the crash.

If this is not possible can you describe exactly what you are moving from where to where when reordering items in the 'Floodlight' macro you sent me.
Video sent.

For the benefit of any others I cannot discern a pattern other than they contain IF clauses. I can move all sorts of actions around within the macro but if I move an IF clause or move something in/out of an IF clause then macrodroid just shuts down.
 

MacroDroidDev

Administrator
Staff member
I've just downloaded v5.37.4 and notice that IF CONFIRMED THEN action doesn't work anymore. I mean it's impossible to create a new macro with it: the line appears with a warning on pink background. As well as previous macros with such an action cannot be updated/saved anyway for the same reason. Thanks @MacroDroidDev for having a look on it...
Thanks for alerting me to this. I forgot that this is a child of the standard IF condition action and it seems to have inherited it's validity check which it certainly shouldn't be. I will get this fixed and a new beta out as soon as I can.
 

MacroDroidDev

Administrator
Staff member
@CDA Thanks for sharing the video. I can recreate the issue now and it seems to be related to when the IF statements are collapsed. I'm going to look for a fix right now.
 

CDA

Member
@CDA Thanks for sharing the video. I can recreate the issue now and it seems to be related to when the IF statements are collapsed. I'm going to look for a fix right now.

You have no idea how much of relief it is to know I am not going mad! haha.
Thanks for the update.
 
Top