V5.40 - Feedback

MacroDroidDev

Administrator
Staff member
For obvious bugs, please use report a bug in troubleshooting section with a clear description.

For other issue and discussions (related only to this beta), please leave all feedback here.
 

Jacob L

Moderator (Lawsonator)
I get a crash if I try to use the enable disable trigger action. To reproduce:

Create a blank macro with no name or trigger. Add the enable trigger action > select another macro. Notice the dialog is empty. Now press the ok button. Crash!
 

Elieston

Member
The dialog box doesn't show the values in the same sequence as they are in the variable. But the value is correct with its position. For example: the fifth print item is 14, but the choice will insert 05.
 

Attachments

  • Screenshot_2024-01-05-20-16-00-803_com.arlosoft.macrodroid.jpg
    Screenshot_2024-01-05-20-16-00-803_com.arlosoft.macrodroid.jpg
    130.9 KB · Views: 16
  • Alarme.macro
    58.7 KB · Views: 9
Last edited by a moderator:

Elieston

Member
First thank you very much, the dialog box returned to normal.
The regular interval trigger is losing the configuration when it updates.
 

Attachments

  • Screenshot_2024-01-06-06-34-32-250_com.arlosoft.macrodroid.jpg
    Screenshot_2024-01-06-06-34-32-250_com.arlosoft.macrodroid.jpg
    511 KB · Views: 16

MacroDroidDev

Administrator
Staff member
The problem with regular interval happened in 5.40.0. Anyone upgrading from 5.39 to 5.40.1 should not experience this
 

PoorlyWindow549

New member
When you use an WebHook and write ?any variable=any value you can set any variable to any value you like and the string output doesn't work for some reason, 8 don't know if tis is an feature or an bug, but I guess it should be changed.
 

MacroDroidDev

Administrator
Staff member
@Elieston Just to be clear, it was the upgrade from 5.39.4 - > 5.40.0 that broke this and it will remain broken if you upgrade from 5.40.0 to 5.40.1

If you restore an old macro set created with 5.39.4 directly into 5.40.1 the issue will not happen.
 

MacroDroidDev

Administrator
Staff member
When you use an WebHook and write ?any variable=any value you can set any variable to any value you like and the string output doesn't work for some reason, 8 don't know if tis is an feature or an bug, but I guess it should be changed.

@PoorlyWindow549 Sorry but I don't understand what you mean by this. I just tested calling a webhook with the following query parameter:

?str=123

and my local string variable updated to "123" as expected.

If you are sure there is a problem please give a very explicit example of what is failing.
 

PoorlyWindow549

New member
If this is how it is supposed to work, I just want to point out that the "text" after the ? in the webhook does not go into the string variable that you configure in the webhook, but that in the example ?str=123 the variable str is set to 123, but if I tell the webhook to insert it into the variable str2, the message is not inserted into str2, so str=123 does not go into the variable str2, which is messy as long as there was an option to disable the current function, because now if you know the webhook from another person's macro you could empty the variables in that macro or set them to any value.
 

MacroDroidDev

Administrator
Staff member
@PoorlyWindow549 Sorry but I am completely unable to follow what you are saying. Can you state clearly what the problem is. If you want it inserted in str2 then you just send it as ?str2=123
 

PoorlyWindow549

New member
@PoorlyWindow549 Sorry but I am completely unable to follow what you are saying. Can you state clearly what the problem is. If you want it inserted in str2 then you just send it as ?str2
@PoorlyWindow549 Sorry but I am completely unable to follow what you are saying. Can you state clearly what the problem is. If you want it inserted in str2 then you just send it as ?str2=123
Ok, when I create a webhook I can send values after the ? in the following format: ...?Str=123 and the variable named Str is set to 123, which also works for other variables. I have now made the experience that if I define a string variable as output in the webhook, this is not used, example: ...?text, then the string variable configured in the webhook is not set to text. This is the 1st thing that this string variable as output in the webhook does not work for me. 2. my concerns about this system with ...?Str=123, that then the variable Str is set to 123, would be that if you know the webhook URL from a webhook in a macro from a person, you could theoretically change the values in this macro at will, so I would think it would make sense if there was an option in the webhook to deactivate this function with ...?Str=123 and then simply get an output via the string variable defined in the webhook.
 

Josué García

MacroDroid Support
Staff member
@PoorlyWindow549 I think I understood your concern

If you mean that if you share a macro in the template store your webhook is shared and a 3rd party can manage your variables.

When you export or import, your identifier is not shared.

Only that the user places it in the actions, for example an HTTP request, but then it will be understood that the user wanted to share that information.

Otherwise, you can activate the IP address whitelist, that way you will never have an unwanted intruder (which I have never heard of this happening already).
 

PoorlyWindow549

New member
@PoorlyWindow549 I think I understood your concern

If you mean that if you share a macro in the template store your webhook is shared and a 3rd party can manage your variables.

When you export or import, your identifier is not shared.

Only that the user places it in the actions, for example an HTTP request, but then it will be understood that the user wanted to share that information.

Otherwise, you can activate the IP address whitelist, that way you will never have an unwanted intruder (which I have never heard of this happening already).
I know, but for example, I'm planning an Project with Webhooks, where I need to have an "Server" Macro with an public webhook ID, and there it would be pretty bad if someone could just wipe the database with one webhook request, so I would need for this and other projects a possibility of getting data transferred over a webhook to a string variable.
 

Endercraft

Moderator (& bug finder :D)
Encountered this issue too, it's true that it would be nice to have this. I think if you put the characters "?" and "&" in your variable names nobody will be able to modify it.
 
Top